Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3203: Add Auto-refreshing Official CVE feed #3204

Merged
merged 3 commits into from
Jun 16, 2022
Merged

KEP-3203: Add Auto-refreshing Official CVE feed #3204

merged 3 commits into from
Jun 16, 2022

Conversation

PushkarJ
Copy link
Member

@PushkarJ PushkarJ commented Feb 1, 2022

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 1, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/security Categorizes an issue or PR as relevant to SIG Security. labels Feb 1, 2022
@PushkarJ PushkarJ mentioned this pull request Feb 1, 2022
Open
14 tasks
@PushkarJ
Copy link
Member Author

PushkarJ commented Feb 1, 2022

/cc tabbysable sftim nehaLohia27

@PushkarJ PushkarJ changed the title KEP-3203: Add Auto-refreshing Official CVE feed KEP KEP-3203: Add Auto-refreshing Official CVE feed Feb 10, 2022
@tabbysable
Copy link
Member

/hold for commentary

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2022
@PushkarJ PushkarJ mentioned this pull request Feb 11, 2022
Closed
sftim
sftim reviewed Feb 14, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback (nothing major)

@PushkarJ PushkarJ force-pushed the kep-3203 branch 2 times, most recently from ae8bef7 to 73fa4f7 Compare February 16, 2022 22:02
@ehashman
Copy link
Member

Given that this is fully out of tree and doesn't appear to have scope outside of SIG Security (maybe SIG k8s Infra), not sure why this is a KEP? I'll approve for PRR as N/A.

@k8s-ci-robot k8s-ci-robot added the area/enhancements Issues or PRs related to the Enhancements subproject label Feb 25, 2022
@PushkarJ
Copy link
Member Author

/test pull-enhancements-test

@mtardy
Copy link
Member

mtardy commented Jun 7, 2022

The API and the human-friendly document that this KEP will add to the website will be very useful!
/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@PushkarJ PushkarJ force-pushed the kep-3203 branch 2 times, most recently from 3929c16 to c6cb93e Compare June 7, 2022 17:21
@PushkarJ
Copy link
Member Author

PushkarJ commented Jun 7, 2022

K8s Bot is removing LGTMs so I am compiling LGTMs here:

@PushkarJ PushkarJ force-pushed the kep-3203 branch 2 times, most recently from f9acf9c to 5fa3b19 Compare June 7, 2022 18:10
@PushkarJ PushkarJ force-pushed the kep-3203 branch 2 times, most recently from 86d8726 to 2f33463 Compare June 10, 2022 17:24
@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, nehaLohia27, NissesSenap, PushkarJ, tabbysable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2022
PushkarJ and others added 3 commits June 15, 2022 21:12
@PushkarJ
Add Auto-refreshing official CVE feed KEP
710777a 
Updates based on PR feedback
- Revisited section placements
- Added clarity on use of labels under risks
- Update toc
- Apply suggestions from code review
- Added CVE project as non-goal
- Made machine-readability as explicit goal

Updates to use google bucket + dynamic page generation for k/website flow

Added more clarity in alternatives considered section

Co-authored-by: Tim Bannister <[email protected]>

Signed-off-by: Pushkar Joglekar <[email protected]>
@PushkarJ @reylejano
Apply suggestions from code review
2019891 
Co-authored-by: Mahé <[email protected]>
Co-authored-by: Batuhan Apaydın <[email protected]>
Co-authored-by: Cailyn <[email protected]>
And Eric Smalling
Added link to existing options that are broken or incomplete

Add testing sections for v1.25

Co-authored-by: Rey Lejano <[email protected]>
@PushkarJ
Update PRR approver
2c44303 
ehashman->johnbelamaric

kep 3203 add test plan graduation criteria

Signed-off-by: Neha Lohia <[email protected]>
@tabbysable
Copy link
Member

@PushkarJ go ahead and slash-unhold when you're ready
/lgtm again for posterity :-)

@PushkarJ
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2022
@nehaLohia27
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6c1a3b1 into kubernetes:master Jun 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 16, 2022
@palnabarun palnabarun mentioned this pull request Jul 26, 2022
Closed
@cailyn-codes cailyn-codes mentioned this pull request Sep 1, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@cblecker cblecker cblecker left review comments

@cailyn-codes cailyn-codes cailyn-codes left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@mtardy mtardy mtardy left review comments

@NissesSenap NissesSenap NissesSenap approved these changes

@developer-guy developer-guy developer-guy left review comments

@ericsmalling ericsmalling ericsmalling left review comments

@tallclair tallclair tallclair left review comments

@tabbysable tabbysable tabbysable left review comments

@reylejano reylejano reylejano left review comments

@nehaLohia27 nehaLohia27 nehaLohia27 approved these changes

@IanColdwater IanColdwater Awaiting requested review from IanColdwater

Assignees

@nehaLohia27 nehaLohia27

@mtardy mtardy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/security-response Denotes an issue or PR intended to be handled by the product security committee. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/security Categorizes an issue or PR as relevant to SIG Security. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.